SDL_mixer patch for multiple music streams |
hardcoredaniel
Guest
|
Hi,
I merged the changes for multiple music streams from Nikos Chantziaras from here: https://bitbucket.org/realnc/sdl_mixer into a recent version of SDL_mixer here: https://bitbucket.org/hcdaniel/wmelite-dependencies-for-linux-and-android/src/0977f18b6b21d577a926edab26521396c5421a96/dependencies/SDL_mixer/jni/ My repo, however, has other changes to SDL_mixer too (callback functions enhanced to work with C++, some additional features to the mixer). I tested the changes with OGG only, so it might be that I have overlooked something. Is there interest to get the "multiple music streams" feature merged into SDL_mixer? Regards, Daniel |
|||||||||||
|
SDL_mixer patch for multiple music streams |
Joseph Carter
|
You'd probably want to split out your callbacks into a separate patch and make the case for them separately. Particularly if they're usefully language-agnostic, the case might be easily made depending what they do.
JosephSent via mobile On Jan 5, 2015, at 01:59, hardcoredaniel wrote:
|
|||||||||||||
|
SDL_mixer patch for multiple music streams |
hardcoredaniel
Guest
|
Hi,
yes, there is already an entry in the database for the callback function change: https://bugzilla.libsdl.org/show_bug.cgi?id=2462 It changes the API, but won't otherwise have any effect on C programs (the extra pointer can be NULL if unused). For C++ it's very convenient to supply a reference to a class instance, which makes life easy esp. if you have one instance per mixer channel (resp. music channel if you include the multiple music channels patch). Regards, Daniel ---------- Původnà zpráva ---------- Od: T. Joseph Carter Komu: SDL Development List Datum: 6. 1. 2015 13:13:17 Předmět: Re: [SDL] SDL_mixer patch for multiple music streams
|
|||||||||||||||
|