Re: Mac OS X Universal Binary Frameworks built? |
Re: Mac OS X Universal Binary Frameworks built? |
Andras Salamon
Guest
|
On Mon, Jan 09, 2006 at 10:44:25AM +0100, Christian Walther wrote:
Does this mean we can get rid of the ancient, Mac-specific, pre-10.1 hacks regarding semaphores and threading? For instance, in src/thread/linux/SDL_syssem.c there is #ifdef MACOSX #define USE_NAMED_SEMAPHORES /* Broken sem_getvalue() in MacOS X Public Beta */ #define BROKEN_SEMGETVALUE #endif /* MACOSX */ and later #ifdef BROKEN_SEMGETVALUE /* This is a little hack for MacOS X - It's not thread-safe, but it's better than nothing */ int sem_value; #endif Perhaps someone knows _why_ the BROKEN_SEMGETVALUE hack was introduced (CVS history for this file only seems to start in 2001). Is there test code that demonstrates a problem, or is there some other compelling reason to mess with semaphores in the presence of threading on Mac OS X? I don't think SDL should be tiptoeing around bugs in a 5 year old beta this way. Further, in src/thread/linux/SDL_systhread.c appears, twice: #if !defined(MACOSX) /* pthread_sigmask seems to be missing on MacOS X? */ while my 10.3.9 system has (not sure when it was introduced): /usr/include/pthread.h:int pthread_sigmask(int, const sigset_t *, sigset_t *); Building with these hacks removed results in code that seems less prone to weird asynchronous behaviour in network code that uses the SDL synchronization primitives, at least in my experience. -- Andras Salamon andras at dns.net |
|||||||||||||
|
Re: Mac OS X Universal Binary Frameworks built? |
Sam Lantinga
Guest
|
These were for bugs in the public beta and MacOS X 10.0 (10.1?)
Ryan, can you confirm that these are not problems in 10.2 and then nuke them? Thanks!
|
|||||||||||||||||||||||||||||||||||||||
|
Re: Mac OS X Universal Binary Frameworks built? |
Ryan C. Gordon
Guest
|
Sam Lantinga wrote:
Will do. https://bugzilla.libsdl.org/show_bug.cgi?id=64 --ryan. |
|||||||||||||
|