The SDL forums have moved to discourse.libsdl.org.
This is just a read-only archive of the previous forums, to keep old links working.

Hi,
I just wanted to ask for review of the patches attached to these bugs, all related to SDL_WINDOW_FULLSCREEN on OS X:

https://bugzilla.libsdl.org/show_bug.cgi?id=2479 ([OS X] SDL_SetWindowFullscreen fails to switch to windowed)
https://bugzilla.libsdl.org/show_bug.cgi?id=2550 ([OS X 10.9] Enabling SDL_WINDOW_FULLSCREEN after relative mouse mode leaves cursor visible)
https://bugzilla.libsdl.org/show_bug.cgi?id=2534 ([Patch] Mac: black bar at top of screen in SDL_WINDOW_FULLSCREEN mode)

I’ve tested[1] the patches on two machines, OS X 10.9.3 and 10.6.8, and the fixes seem solid to me.

Thanks,
Eric

[1] I tested them by experimenting with the testdraw2 SDL sample app, as well as playing Quakespasm, which I’m currently working on porting to SDL2 from SDL1.2 - https://sourceforge.net/p/quakespasm/patches/22/
_______________________________________________
SDL mailing list

http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org

Thanks for checking these. The fixes look good and are committed.


Cheers!



On Sat, May 31, 2014 at 12:58 PM, Eric Wasylishen wrote: