DirectInput joystick driver's XInput detection broken on Win |
Mikkel Krautz
Guest
|
Hi,
We use the XInput detection code from SDL's DirectInput joystick code in Mumble (https://www.mumble.info). This is the code I am talking about: https://hg.libsdl.org/SDL/file/e8281b14970c/src/joystick/windows/SDL_dinputjoystick.c#l238 We just received a bug report that the detection is broken on Windows 10 Anniversary Update (1607): https://github.com/mumble-voip/mumble/issues/2483 I debugged it for a bit, and it doesn't seem like the "IG_" check works anymore when using the anniversary update. The "IG_" check is this: https://hg.libsdl.org/SDL/file/e8281b14970c/src/joystick/windows/SDL_dinputjoystick.c#l296 For now, we've worked around the issue by adding GUIDs for wired/wireless/bluetooth Xbox One controllers to the list of well known XInput devices: https://github.com/mumble-voip/mumble/pull/2484 This works around the issue for people using Xbox One controllers. If there is any interest, feel free to copy the GUIDs from the PR above into SDL, under SDL's MIT license. Thanks, Mikkel _______________________________________________ SDL mailing list http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org |
|||||||||||
|
DirectInput joystick driver's XInput detection broken on Win |
Daniel Gibson
Guest
|
On 08/04/2016 02:35 AM, Mikkel Krautz wrote:
SDL uses zlib licence, not MIT license
Cheers, Daniel _______________________________________________ SDL mailing list http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org |
|||||||||||||||
|
DirectInput joystick driver's XInput detection broken on Win |
Mikkel Krautz
Guest
|
On Thu, Aug 4, 2016 at 2:50 AM, Daniel Gibson wrote:
Whoops. If there's any interest, feel free to copy the GUIDs from the PR above into SDL, under SDL's *zlib* license. :-) _______________________________________________ SDL mailing list http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org |
|||||||||||||||
|
DirectInput joystick driver's XInput detection broken on Win |
Mikkel Krautz
Guest
|
I've moved this thread to Bugzilla:
https://bugzilla.libsdl.org/show_bug.cgi?id=3403 Please keep up with the issue there instead. :-) _______________________________________________ SDL mailing list http://lists.libsdl.org/listinfo.cgi/sdl-libsdl.org |
|||||||||||
|