RFC natural scrolling handling on Mac OS X |
urkle
|
Sam,
I've finally gotten to redoing this patch.. Could you give it a once-over and give your thoughts before I push the commits ? https://gist.github.com/urkle/3c398a19c811f0865c17 Edward Rudd OutOfOrder.cc Skype: outoforder_cc 317-366-7906 On Mar 1, 2014, at 17:42, Edward Rudd wrote:
|
|||||||||||||||||||||||||||||||
|
RFC natural scrolling handling on Mac OS X |
Sam Lantinga
|
In general, without context it seems weird that sometimes you'll get reversed input, especially with the comment in the header. Â "Why would they be reversed, WTF?" Maybe expand the comment to describe when and why this would happen? Also maybe change the enumeration to NORMAL and NATURAL, to indicate intent?
Here are a few more notes: * Typo:Â When REVSERED * Type is Uint32, but cast to int:Â event.wheel.reversed = (int)reversed; * Instead of "reversed", can you change it to "direction"? It's not a bool, it's an enumeration. On Sun, Nov 23, 2014 at 7:57 PM, Edward Rudd wrote:
|
|||||||||||||||||||||||||||||||||||||||||
|
RFC natural scrolling handling on Mac OS X |
urkle
|
I thought about naming it direction instead of reversed as well.. I can call it direction instead as that does make it clearer.
The reason I went with with REVERSED for the enum was that "natural" is an apple "opinion" on their naming.. and wasn’t sure if that would be universally understandable across platforms. maybe NORMAL and FLIPPED ? I updated the gist diff.. (also noticed some accidental find/replace changes that should not have occured) On Nov 29, 2014, at 2:33 PM, Sam Lantinga wrote:
|
|||||||||||||||||||||||||||||||||||||||||||||
|
RFC natural scrolling handling on Mac OS X |
Sam Lantinga
|
Looks good, go ahead and push it.
Thanks! On Mon, Dec 1, 2014 at 7:31 AM, Edward Rudd wrote:
|
|||||||||||||||||||||||||||||||||||||||||||||||
|
RFC natural scrolling handling on Mac OS X |
urkle
|
It’s pushed.. and all the builds are passing now.
Edward Rudd OutOfOrder.cc Skype: outoforder_cc 317-366-7906 On Dec 2, 2014, at 3:03 AM, Sam Lantinga wrote:
|
|||||||||||||||||||||||||||||||||||||||||||||||||
|
RFC natural scrolling handling on Mac OS X |
Sam Lantinga
|
Great, thanks!
On Wed, Dec 3, 2014 at 8:10 AM, Edward Rudd wrote:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
|